Compare against a list not a string#8
Compare against a list not a string#8alop merged 2 commits intoCiscoSystems:cis-havanafrom retr0h:DE778
Conversation
The `CONF.ldap.builtin_users` is configured as a comma delimited string, and needs to be converted to a list before comparison. Closes-rally-bug: DE778 Not-in-upstream: true
|
👍 |
1 similar comment
|
👍 |
There was a problem hiding this comment.
Any chance this would be a type other than a string? This would result in a syntax error if say CONF.ldap.builtin_users a number and an attribute error if CONF.ldap.builtin_users was None. I am unsure how the keystone config behaves so it may do sane defaults for example if CONF.ldap.builtin_users was not specified in the config.
|
This has been addressed as part of the fix in PR - #5 Not sure why it hasn't been considered for merge instead? |
|
@schoksey we are discussing it now. |
|
+1 |
|
@schoksey we opted to go this route unless told otherwise. Your pull request looks good, and we can work on merging that. However, it has changes outside the scope of what was reported in DE778. If we wish to get those changes in we will need unit tests, and a story associated with this feature/perf enhancements. |
|
makes sense. will work on a separate user story/unit test creation for PR - #5 |
Compare against a list not a string
6 participants
The
CONF.ldap.builtin_usersis configured as a comma delimited string, andneeds to be converted to a list before comparison.
Closes-rally-bug: DE778
Not-in-upstream: true